Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem solution access check; fixes #1371 #1425

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Fix problem solution access check; fixes #1371 #1425

merged 1 commit into from
Jun 6, 2020

Conversation

Ninjaclasher
Copy link
Member

Fixes #1371.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2020 •
edited
Loading

Codecov Report

Merging #1425 into master will decrease coverage by 0.01%.
The diff coverage is 11.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1425      +/-   ##
==========================================
- Coverage   37.91%   37.90%   -0.02%     
==========================================
  Files         198      198              
  Lines       11340    11349       +9     
==========================================
+ Hits         4300     4302       +2     
- Misses       7040     7047       +7
Impacted Files Coverage Δ
judge/models/comment.py 38.81% <4.16%> (ø)
judge/models/problem.py 51.03% <22.22%> (-0.93%) ⬇️
judge/views/problem.py 25.20% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31215fe...12fb400. Read the comment docs.

@Ninjaclasher Ninjaclasher force-pushed the solution-access branch 3 times, most recently from ab9ab0c to 339844b Compare June 4, 2020 20:21
@Ninjaclasher Ninjaclasher marked this pull request as ready for review June 4, 2020 20:35
Xyene
Xyene approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xyene Xyene merged commit e1e2a3e into DMOJ:master Jun 6, 2020
@Ninjaclasher Ninjaclasher deleted the solution-access branch June 6, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xyene Xyene Xyene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comment access check for problem solutions is incorrect
3 participants
@Ninjaclasher @codecov-commenter @Xyene